Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix MenuItem windowMenu role description #17065

Merged
merged 1 commit into from Feb 25, 2019
Merged

docs: fix MenuItem windowMenu role description #17065

merged 1 commit into from Feb 25, 2019

Conversation

sindresorhus
Copy link
Contributor

@sindresorhus sindresorhus commented Feb 20, 2019

The behavior was changed in #15930

Notes: Fixed MenuItem windowMenu role description to account for changing of Close to Zoom.

@sindresorhus sindresorhus requested a review from a team February 20, 2019 11:21
@welcome
Copy link

welcome bot commented Feb 20, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@codebytere codebytere merged commit df5305d into electron:master Feb 25, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 25, 2019

Release Notes Persisted

Fixed MenuItem windowMenu role description to account for changing of Close to Zoom.

@trop
Copy link
Contributor

trop bot commented Feb 25, 2019

I have automatically backported this PR to "5-0-x", please check out #17118

@sofianguy sofianguy added this to Fixed in 5.0.0-beta.4 in 5.0.x Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.0-beta.4
Development

Successfully merging this pull request may close these issues.

None yet

2 participants