Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix race condition in debugger spec #17091

Merged
merged 1 commit into from Feb 23, 2019
Merged

test: fix race condition in debugger spec #17091

merged 1 commit into from Feb 23, 2019

Conversation

nornagon
Copy link
Member

Description of Change

the webContents here is a remote object, so event listeners must be attached before the event they're listening for could be generated.

cc @jkleinsc #16861 (comment)

Checklist

Release Notes

Notes: no-notes

@nornagon nornagon requested a review from a team February 22, 2019 00:46
@MarshallOfSound MarshallOfSound added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Feb 22, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 22, 2019
nitsakh
nitsakh approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@nitsakh nitsakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nornagon nornagon merged commit 28b150f into master Feb 23, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 23, 2019

No Release Notes

@nornagon nornagon deleted the flake branch February 23, 2019 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitsakh nitsakh nitsakh approved these changes

Assignees
No one assigned
Labels
new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nornagon @nitsakh @MarshallOfSound