fix: access of out-of-scope reference in ShowOpenDialog

[jfuechsl]

and also in and ShowSaveDialog.

Description of Change

In the mac file dialog implementation of show*OpenDialog, a settings
object is passed down to the dialog completion handler.
However at the time the completion handler is invoked, the settings
object is already out-of-scope, resulting in an invalid access to
the security_scoped_bookmarks flag.
The fix is to capture the value of the flag and passing that directly
to the completion handler.

Closes #16664

Checklist

• PR description included and stakeholders cc'd
• npm test passes (I get timeouts and seemingly unrelated failures)
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed a bug when retrieving security scoped bookmarks in ShowOpenDialog and ShowSaveDialog

[welcome]

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[release-clerk]

Release Notes Persisted

Fixed a bug when retrieving security scoped bookmarks in ShowOpenDialog and ShowSaveDialog

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[MarshallOfSound]

/trop run backport-to 4-0-x,5-0-x

[trop]

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "4-0-x" here we go! :D

[trop]

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

[trop]

I have automatically backported this PR to "4-0-x", please check out #17176

[trop]

I have automatically backported this PR to "5-0-x", please check out #17177