Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove an unused header #17158

Merged
merged 1 commit into from Feb 28, 2019
Merged

chore: remove an unused header #17158

merged 1 commit into from Feb 28, 2019

Conversation

alexeykuzmin
Copy link
Contributor

@alexeykuzmin alexeykuzmin commented Feb 27, 2019 •
edited

Description of Change

Remove an unused header. It's already removed in the master and the 5-0-x release branch.
Refs #16772.

Checklist

Release Notes

Notes: no-notes

@alexeykuzmin alexeykuzmin requested a review from a team February 27, 2019 15:23
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 27, 2019
nornagon
nornagon approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor

@ckerr ckerr added the semver/patch backwards-compatible bug fixes label Feb 27, 2019
@ckerr
Copy link
Member

ckerr commented Feb 27, 2019

norris

@alexeykuzmin
Copy link
Contributor Author

imdoingmypart

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 28, 2019
@alexeykuzmin alexeykuzmin merged commit 0efccf4 into 4-0-x Feb 28, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 28, 2019

No Release Notes

@alexeykuzmin alexeykuzmin deleted the remove-a-header-file branch February 28, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@nornagon nornagon nornagon approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@miniak miniak miniak approved these changes

@codebytere codebytere codebytere approved these changes

@nitsakh nitsakh nitsakh approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@alexeykuzmin @ckerr @nornagon @jkleinsc @deepak1556 @miniak @codebytere @nitsakh @MarshallOfSound