Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: access of out-of-scope reference in ShowOpenDialog (backport: 4-0-x) #17176

Commits on Feb 28, 2019

  1. fix: access of out-of-scope reference in ShowOpenDialog and ShowSaveD…

    …ialog
    
    In the mac file dialog implementation of show*OpenDialog, a settings
    object is passed down to the dialog completion handler.
    However at the time the completion handler is invoked, the settings
    object is already out-of-scope, resulting in an invalid access to
    the security_scoped_bookmarks flag.
    The fix is to capture the value of the flag and passing that directly
    to the completion handler.
    
    fixes issue electron#16664
    jfuechsl authored and electron-bot committed Feb 28, 2019
    Copy the full SHA
    d9fb72e View commit details
    Browse the repository at this point in the history