Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash in ECDH.setPrivateKey #17219

Merged
merged 1 commit into from Mar 8, 2019
Merged

fix: crash in ECDH.setPrivateKey #17219

merged 1 commit into from Mar 8, 2019

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Mar 4, 2019 •
edited

Description of Change

Backports https://boringssl-review.googlesource.com/c/boringssl/+/35124

Closes #16477

Checklist

Release Notes

Notes: Fixed a crash when calling ECDH.setPrivateKey().

@nornagon nornagon requested a review from codebytere March 4, 2019 19:05
@nornagon
Copy link
Member Author

nornagon commented Mar 4, 2019

Depends on #17220

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Mar 4, 2019
@chevonc chevonc mentioned this pull request Mar 8, 2019
Closed
@nornagon nornagon requested a review from a team as a code owner March 8, 2019 17:45
codebytere
codebytere approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending green ci, looks good :)

looks like it's gonna need manual to 4 tho, unfort

@nornagon nornagon merged commit 34fb6c2 into master Mar 8, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 8, 2019

Release Notes Persisted

Fixed a crash when calling ECDH.setPrivateKey().

@trop
Copy link
Contributor

trop bot commented Mar 8, 2019

I was unable to backport this PR to "4-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Mar 8, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Mar 8, 2019

I have automatically backported this PR to "5-0-x", please check out #17296

@codebytere codebytere deleted the fix-setprivatekey-crash branch March 8, 2019 18:52
@nornagon nornagon mentioned this pull request Mar 8, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Mar 8, 2019

A maintainer has manually backported this PR to "4-0-x", please check out #17297

@trop
Copy link
Contributor

trop bot commented Mar 8, 2019

A maintainer has manually backported this PR to "4-0-x", please check out #17297

@sofianguy sofianguy added this to Fixed in 5.0.0-beta.6 in 5.0.x Mar 20, 2019
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@nornagon @kiku-jw
fix: crash in ECDH.setPrivateKey (electron#17219)
f941599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.0-beta.6
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @codebytere