fix: backport upstream fixes for color chooser dialogs #17227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can use https://chromiumdash.appspot.com/commits to find out which version a commit has landed in. Also with upstream backports its not necessary to find out and specify the version, our |
deepak1556
approved these changes
Mar 5, 2019
nornagon
requested changes
Mar 5, 2019
|
I updated the patches, thanks for the guidance @nornagon! |
brenca
force-pushed
the
brenca/color-chooser
branch
from
016b984
to
063d8b2
Compare
nornagon
approved these changes
Mar 6, 2019
|
Release Notes Persisted
|
|
I have automatically backported this PR to "5-0-x", please check out #17254 |
|
Should the release notes also mention the DCHECK fix on windows ? |
|
DCHECK generally isn't observable by app devs, so I'd say no. |
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
* fix: backport upstream fixes for color chooser dialogs * chore: fix patches, Windows bad, linux good * Update color_chooser_mac.patch * Update color_chooser_win.patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #13596 and replaces an old patch with a better one. Both patches should be removed once we get to a chromium version that includes the two fixes:
https://chromium-review.googlesource.com/c/chromium/src/+/1479332
https://chromium-review.googlesource.com/c/chromium/src/+/1469461
Not sure which version that would be, maybe @nornagon can help me with that.
The Windows fix is there to avoid a
DCHECK, so I left that out of the release notes, since no user should see a debug build.Checklist
npm testpassesRelease Notes
Notes: Backported a fix for crashing color picker dialogs on MacOS.