Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promisify session.clearAuthCache() #17259

Merged
merged 2 commits into from Mar 9, 2019
Merged

feat: promisify session.clearAuthCache() #17259

merged 2 commits into from Mar 9, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Mar 7, 2019 •
edited

Description of Change

Promisifies session.clearAuthCache().

Checklist

Release Notes

Notes: Converted session.clearAuthCache() to return a promise instead of optionally taking a callback.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 7, 2019
@codebytere codebytere force-pushed the promisify-clearauthcache branch 5 times, most recently from 203b76b to 3ca656b Compare March 8, 2019 04:59
@codebytere codebytere added semver/major incompatible API changes semver/minor backwards-compatible functionality and removed semver/major incompatible API changes labels Mar 8, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 8, 2019
deepak1556
deepak1556 approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with style change.

atom/browser/api/atom_api_session.cc Show resolved Hide resolved
@codebytere codebytere merged commit 9ea6c01 into master Mar 9, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 9, 2019 •
edited by codebytere

Release Notes Persisted

Converted session.clearAuthCache() to return a promise instead of optionally taking a callback.

@codebytere codebytere deleted the promisify-clearauthcache branch March 9, 2019 02:41
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
feat: promisify session.clearAuthCache() (electron#17259)
be8fe46 
* feat: promisify session.clearAuthCache()

* remove unused callback runner helpers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@miniak miniak miniak approved these changes

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @deepak1556 @miniak