Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make StreamSubscriber ref counted (backport: 5-0-x) #17264

Merged
merged 1 commit into from Mar 7, 2019
Merged

fix: make StreamSubscriber ref counted (backport: 5-0-x) #17264

merged 1 commit into from Mar 7, 2019

Commits on Mar 7, 2019

  1. fix: make StreamSubscriber ref counted 

    It is owned by URLRequestStreamJob on the IO thread once request starts,
but if the ownership was abondoned while transfering it to IO thread
which is possible when a request is aborted, then we need to make sure
its destroyed on the right thread to avoid lock in v8.
    @deepak1556 @electron-bot
    deepak1556 authored and electron-bot committed Mar 7, 2019
    Copy the full SHA
    4c7f8c9 View commit details
    Browse the repository at this point in the history