fix: improve focused menu bar item visibility #17291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brenca would you mind including a before and after screenshot? |
|
@codebytere Created some GIFs to illustrate the problem |
codebytere
approved these changes
Mar 8, 2019
MarshallOfSound
approved these changes
Mar 8, 2019
|
Release Notes Persisted
|
|
I have automatically backported this PR to "5-0-x", please check out #17360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
It looks like during the C73 upgrade we lost the highlight on the focused menu bar items (there was a small dotted border around the text of the focused item). This is bad because you can now navigate the menu with just the keyboard, and you can't tell which top level item you are currently on.
This PR enables the background highlighting of the
InkDropfor the focused item, giving some visual feedback to the user when navigating with the keyboard. Also, I made the highlight a tiny bit darker to make it easier to see.This is what we had before the C73 upgrade:
After the upgrade:
With this PR:
Checklist
npm testpassesRelease Notes
Notes: Improved the visibility of the focused item on the menu bar.