Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promisify session.getBlobData() #17303

Merged
merged 1 commit into from Mar 14, 2019
Merged

feat: promisify session.getBlobData() #17303

merged 1 commit into from Mar 14, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Mar 9, 2019 •
edited

Description of Change

Promisifies session.getBlobData().

cc @deepak1556 @miniak @zcbenz

Checklist

Release Notes

Notes: Converted session.getBlobData() to return a Promise instead of taking a callback.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 9, 2019
@codebytere codebytere force-pushed the promisify-session-getblobdata branch from b619aa4 to faa97e2 Compare March 9, 2019 00:05
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 10, 2019
@codebytere codebytere force-pushed the promisify-session-getblobdata branch from faa97e2 to 896ba3b Compare March 11, 2019 18:13
@codebytere codebytere added the semver/minor backwards-compatible functionality label Mar 11, 2019
@codebytere codebytere force-pushed the promisify-session-getblobdata branch 3 times, most recently from 8f6f474 to e0470f9 Compare March 12, 2019 22:32
zcbenz
zcbenz requested changes Mar 13, 2019
View reviewed changes
atom/browser/atom_blob_reader.cc Outdated Show resolved Hide resolved
atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved
atom/browser/atom_blob_reader.cc Outdated Show resolved Hide resolved
@codebytere codebytere added semver/major incompatible API changes and removed semver/minor backwards-compatible functionality labels Mar 13, 2019
@codebytere codebytere requested a review from zcbenz March 13, 2019 15:41
@codebytere codebytere force-pushed the promisify-session-getblobdata branch from 0c7cc4c to f8e0e25 Compare March 13, 2019 20:58
@codebytere codebytere force-pushed the promisify-session-getblobdata branch from f8e0e25 to c5fffe3 Compare March 13, 2019 20:59
@codebytere codebytere merged commit aa8b66a into master Mar 14, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 14, 2019

Release Notes Persisted

Converted session.getBlobData() to return a Promise instead of taking a callback.

@codebytere codebytere deleted the promisify-session-getblobdata branch March 14, 2019 15:11
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
feat: promisify session.getBlobData() (electron#17303)
d4dcbb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound left review comments

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
semver/major incompatible API changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @zcbenz @MarshallOfSound