Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove non-existent gpu-crashed event on <webview> #17317

Merged
merged 1 commit into from Mar 12, 2019
Merged

fix: remove non-existent gpu-crashed event on <webview> #17317

merged 1 commit into from Mar 12, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Mar 10, 2019 •
edited

Description of Change

There is no such event implemented. WebContents would have to emit gpu-crashed (similar to crashed and plugin-crashed).

Checklist

Release Notes

Notes: Remove non-existent gpu-crashed event on <webview>.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 10, 2019
@miniak miniak self-assigned this Mar 10, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 11, 2019
MarshallOfSound
MarshallOfSound approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol... Where did this go, oh well

@MarshallOfSound MarshallOfSound merged commit 48a95f9 into master Mar 12, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 12, 2019

Release Notes Persisted

Remove non-existent gpu-crashed event on <webview>.

@MarshallOfSound MarshallOfSound deleted the miniak/webview-gpu-crashed branch March 12, 2019 00:27
@alexeykuzmin
Copy link
Contributor

@miniak , can you please backport it to 5-0-x, and 4-1-x? if those branches are affected too.

@miniak
Copy link
Contributor Author

miniak commented Apr 27, 2019

/trop run backport-to 4-1-x

@trop
Copy link
Contributor

trop bot commented Apr 27, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "4-1-x" here we go! :D

@miniak
Copy link
Contributor Author

miniak commented Apr 27, 2019

/trop run backport-to 5-0-x

@trop
Copy link
Contributor

trop bot commented Apr 27, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Apr 27, 2019

I was unable to backport this PR to "4-1-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 27, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

miniak added a commit that referenced this pull request Apr 27, 2019
@miniak
fix: remove non-existent gpu-crashed event on <webview> (#17317)
ed360c3
miniak added a commit that referenced this pull request Apr 27, 2019
@miniak
fix: remove non-existent gpu-crashed event on <webview> (#17317)
fc6ce64
@miniak miniak mentioned this pull request Apr 27, 2019
Merged
5 tasks
@trop
Copy link
Contributor

trop bot commented Apr 27, 2019

A maintainer has manually backported this PR to "4-1-x", please check out #18003

1 similar comment
@trop
Copy link
Contributor

trop bot commented Apr 27, 2019

A maintainer has manually backported this PR to "4-1-x", please check out #18003

@trop trop bot added the in-flight/4-1-x label Apr 27, 2019
@miniak miniak mentioned this pull request Apr 27, 2019
Merged
5 tasks
@trop
Copy link
Contributor

trop bot commented Apr 27, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #18004

1 similar comment
@trop
Copy link
Contributor

trop bot commented Apr 27, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #18004

@trop trop bot added the in-flight/5-0-x label Apr 27, 2019
@miniak
Copy link
Contributor Author

miniak commented Apr 27, 2019 •
edited

@alexeykuzmin backported, those branches are affected too

codebytere pushed a commit that referenced this pull request Apr 29, 2019
@miniak @codebytere
fix: remove non-existent gpu-crashed event on <webview> (#17317) (#18004
2f426a0 
)
codebytere pushed a commit that referenced this pull request Apr 29, 2019
@miniak @codebytere
fix: remove non-existent gpu-crashed event on <webview> (#17317) (#18003
3fd0ac6 
)
@sofianguy sofianguy added this to Fixed in 5.0.1 in 5.0.x May 4, 2019
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@miniak @kiku-jw
fix: remove non-existent gpu-crashed event on <webview> (electron#17317)
021d547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees

@miniak miniak

Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.1
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @alexeykuzmin @MarshallOfSound