Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] fix: destroy WebContents synchronously on shutdown (3-1-x) #17395

Closed
wants to merge 1 commit into from
Closed

[wip] fix: destroy WebContents synchronously on shutdown (3-1-x) #17395

wants to merge 1 commit into from

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Mar 15, 2019

Backport #15541 to 3-1-x.

Notes: Fix crash on exit when using BrowserView.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 15, 2019
@miniak miniak mentioned this pull request Mar 15, 2019
Closed
@miniak miniak self-assigned this Mar 15, 2019
@miniak miniak added the wip ⚒ label Mar 15, 2019
@miniak miniak changed the title fix: destroy WebContents synchronously on shutdown (3-1-x) [wip] fix: destroy WebContents synchronously on shutdown (3-1-x) Mar 15, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 16, 2019
@miniak miniak closed this Apr 19, 2019
@miniak miniak deleted the miniak/backport-3-1-x branch April 19, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miniak miniak

Labels
wip ⚒
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@miniak