chore: roll node #17396
Closed
chore: roll node #17396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes: Corrected NODE_MODULE_VERSION to be 70. Native modules will need to be re-built.
6 tasks
|
NB. waiting on this until we have merged Node 12. |
|
cc @nitsakh who's working on rolling node 12 |
|
Closing as duplicate of #17828, which has already been merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NODE_MODULE_VERSIONin the 5-0-x line has been incorrectly set at68. This PR updates it to 70, which is reserved for Electron 5 per nodejs/node#24114Checklist
npm testpassesRelease Notes
Notes: Corrected NODE_MODULE_VERSION to be 70. Native modules will need to be re-built.