Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add <webview>.getWebContentsId() #17407

Merged
merged 1 commit into from Mar 26, 2019
Merged

feat: add <webview>.getWebContentsId() #17407

merged 1 commit into from Mar 26, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Mar 16, 2019 •
edited

Description of Change

Allows getting the WebContents ID of <webview>s when the remote module is disabled.

Checklist

Release Notes

Notes: Added <webview>.getWebContentsId(), which does not depend of the remote module.

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Mar 16, 2019
@miniak miniak requested a review from nornagon March 19, 2019 21:07
@miniak miniak self-assigned this Mar 19, 2019
@miniak miniak marked this pull request as ready for review March 19, 2019 21:12
@miniak miniak requested a review from zcbenz March 19, 2019 21:12
@miniak miniak force-pushed the miniak/webview-webcontents-id branch from abc5cfe to 8d026cf Compare March 19, 2019 21:19
@miniak
Copy link
Contributor Author

miniak commented Mar 19, 2019

@zcbenz, @deepak1556 is it ok to use webContents ID as guestInstanceId to make the implementation simple?

@zcbenz
Copy link
Member

zcbenz commented Mar 19, 2019

@zcbenz, @deepak1556 is it ok to use webContents ID as guestInstanceId to make the implementation simple?

I think it is fine, and it does make code easier to understand.

deepak1556
deepak1556 approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with cheng here, there is no functionality change and it simplifies the code, webContents id is also an ever increasing unique id generated by the browser process.

@zcbenz zcbenz merged commit 546466b into master Mar 26, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 26, 2019

Release Notes Persisted

Added <webview>.getWebContentsId(), which does not depend of the remote module.

@zcbenz zcbenz deleted the miniak/webview-webcontents-id branch March 26, 2019 01:57
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@miniak @kiku-jw
feat: add <webview>.getWebContentsId() (electron#17407)
d6e6635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @zcbenz @deepak1556