Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report module name when require fails in sandboxed renderers #17413

Merged
merged 1 commit into from Mar 19, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Mar 16, 2019

Description of Change

Added missing module name to the exception message thrown when require fails in sandboxed renderers. Follow up to chore: remove deprecated modules internally using remote.require in sandboxed renderer context

Checklist

Release Notes

Notes: Added missing module name to the exception message thrown when require fails in sandboxed renderers.

/cc @tarruda

@miniak miniak requested a review from tarruda March 16, 2019 12:50
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 16, 2019
@miniak miniak self-assigned this Mar 16, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 17, 2019
@MarshallOfSound MarshallOfSound merged commit 7389dfc into master Mar 19, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 19, 2019

Release Notes Persisted

Added missing module name to the exception message thrown when require fails in sandboxed renderers.

@MarshallOfSound MarshallOfSound deleted the miniak/sandbox-require-error branch March 19, 2019 19:09
@miniak
Copy link
Contributor Author

miniak commented Apr 4, 2019

/trop run backport-to 5-0-x

@trop
Copy link
Contributor

trop bot commented Apr 4, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Apr 4, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
3.0.x / 3.1.x
Fixed (3.1.9)
5.0.x
Fixed in 5.0.0-beta.9
Development

Successfully merging this pull request may close these issues.

None yet

2 participants