refactor: Enable network service (Part 1) #17431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
changed the title
deepak1556
changed the title
deepak1556
force-pushed
the
enable_nw_service
branch
from
0cfee31
to
3a58fba
Compare
|
@zcbenz once this is merged, lets spilt up the tasks in #15791 (comment) |
deepak1556
force-pushed
the
enable_nw_service
branch
from
3a58fba
to
a4ab3a2
Compare
5 tasks
deepak1556
force-pushed
the
enable_nw_service
branch
from
a4ab3a2
to
f22c94e
Compare
zcbenz
approved these changes
Mar 22, 2019
|
No Release Notes |
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
* Convert InspectableWebContentsImpl::LoadNetworkResource to SimpleURLLoader https://bugs.chromium.org/p/chromium/issues/detail?id=721408 * Plumb creation of network context with the service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is first in the series of network refactors to enable the network service as default. The PR allows creation of network context from the service rather than using the legacy apis. There are no functionality changes in this PR, the existing code path are guarded behind network service feature flag so that we can remove the old code path incrementally.
Refs #15791
Checklist
npm testpassesRelease Notes
Notes: no-notes