Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update sandbox-option.md #17468

Merged
merged 2 commits into from Mar 21, 2019
Merged

docs: update sandbox-option.md #17468

merged 2 commits into from Mar 21, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Mar 19, 2019 •
edited

Description of Change

  • update list of modules available in sandbox
  • replace --enable-sandbox command-line argument with app.enableSandbox

Follow up to:

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

/cc @electron/wg-security

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 19, 2019
@miniak miniak requested a review from nornagon March 19, 2019 21:41
@miniak miniak self-assigned this Mar 19, 2019
@miniak miniak requested a review from a team March 19, 2019 21:42
@miniak miniak changed the title docs: mixed mode sandbox is enabled by default + update list of modules available in sandbox docs: update sandbox-option.md Mar 20, 2019
ppontes
ppontes requested changes Mar 20, 2019
View reviewed changes
docs/api/sandbox-option.md Outdated Show resolved Hide resolved
@miniak miniak requested a review from ppontes March 20, 2019 18:45
ppontes
ppontes approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@ppontes ppontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nornagon
nornagon approved these changes Mar 20, 2019
View reviewed changes
docs/api/sandbox-option.md Outdated Show resolved Hide resolved
@nornagon @miniak
Update docs/api/sandbox-option.md
efb3bf9 
Co-Authored-By: miniak <milan.burda@gmail.com>
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 20, 2019
@alexeykuzmin alexeykuzmin merged commit 07b0265 into master Mar 21, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 21, 2019

No Release Notes

@alexeykuzmin alexeykuzmin deleted the miniak/docs-sandbox branch March 21, 2019 13:41
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@miniak @kiku-jw
docs: update sandbox-option.md (electron#17468)
3a3f114 
* docs: update sandbox-option.md

* Update docs/api/sandbox-option.md

Co-Authored-By: miniak <milan.burda@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@ppontes ppontes ppontes approved these changes

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @nornagon @alexeykuzmin @ppontes