fix: close context menu before popup

[zcbenz]

Description of Change

Close #17353.

Fix crash when showing a tray menu while one is already shown.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fix crash when showing a tray menu while one is already shown.

[codebytere]

🎉

[codebytere]

i think this might only be needed on windows? it's failing on macOS as well.

[zcbenz]

It seems that this API is blocking on macOS. I have changed the test to only run on Windows.

[MarshallOfSound]

Unclear if related, if not I'll raise a tracking issue, looks like we have crash-on-exit on osx

0   Electron Framework                  0x0000000112387d19 base::debug::CollectStackTrace(void**, unsigned long) + 9
1   Electron Framework                  0x0000000112250a93 base::debug::StackTrace::StackTrace() + 19
2   Electron Framework                  0x0000000112387bb1 base::debug::(anonymous namespace)::StackDumpSignalHandler(int, __siginfo*, void*) + 2385
3   libsystem_platform.dylib            0x00007fffe7776b3a _sigtramp + 26
4   ???                                 0x00007fff541dd390 0x0 + 140734604628880
5   Electron Framework                  0x0000000112166728 base::ObserverList<atom::api::ExtendedWebContentsObserver, false, true, base::internal::CheckedObserverAdapter>::RemoveObserver(atom::api::ExtendedWebContentsObserver const*) + 120
6   Electron Framework                  0x0000000112164574 atom::api::BrowserWindow::~BrowserWindow() + 148
7   Electron Framework                  0x000000011216477e atom::api::BrowserWindow::~BrowserWindow() + 14
8   Electron Framework                  0x000000011216bf67 base::internal::Invoker<base::internal::BindState<void (mate::TrackableObjectBase::*)(), base::WeakPtr<mate::TrackableObjectBase> >, void ()>::RunOnce(base::internal::BindStateBase*) + 183
9   Electron Framework                  0x00000001122ed363 base::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 323
10  Electron Framework                  0x0000000112309d7f base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*, bool*) + 719
11  Electron Framework                  0x000000011230a39e base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoDelayedWork(base::TimeTicks*) + 158
12  Electron Framework                  0x00000001123bd735 base::MessagePumpCFRunLoopBase::RunWork() + 85
13  Electron Framework                  0x0000000112245d9a base::mac::CallWithEHFrame(void () block_pointer) + 10
14  Electron Framework                  0x00000001123bceff base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63

https://circleci.com/gh/electron/electron/161051

[zcbenz]

@MarshallOfSound It is a known crash: #16580. This PR only affects Windows code.

[release-clerk]

Release Notes Persisted

Fix crash when showing a tray menu while one is already shown.

[trop]

I have automatically backported this PR to "5-0-x", please check out #17509