Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add remote module to docs/tutorial/security.md #17480

Merged
merged 3 commits into from Apr 5, 2019
Merged

docs: add remote module to docs/tutorial/security.md #17480

merged 3 commits into from Apr 5, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Mar 20, 2019 •
edited

Description of Change

With @ppontes help, we finally put together a few words on the remote module in the security guide. Follow up to: #13028, #15014 and #16293

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

/cc @electron/wg-security

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 20, 2019
miniak
miniak commented Mar 20, 2019
View reviewed changes
docs/tutorial/security.md Outdated Show resolved Hide resolved
miniak
miniak commented Mar 20, 2019
View reviewed changes
docs/tutorial/security.md Outdated Show resolved Hide resolved
miniak
miniak commented Mar 20, 2019
View reviewed changes
docs/tutorial/security.md Outdated Show resolved Hide resolved
miniak
miniak commented Mar 20, 2019
View reviewed changes
docs/tutorial/security.md Outdated Show resolved Hide resolved
@miniak miniak self-assigned this Mar 20, 2019
@felixrieseberg
Copy link
Member

This is good stuff and I like it. Do we also want a warning to go with it? Happy to write one.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 21, 2019
ckerr
ckerr reviewed Mar 21, 2019
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice addition. Thanks for adding it, @miniak

docs/tutorial/security.md Outdated Show resolved Hide resolved
docs/tutorial/security.md Outdated Show resolved Hide resolved
docs/tutorial/security.md Outdated Show resolved Hide resolved
docs/tutorial/security.md Outdated Show resolved Hide resolved
docs/tutorial/security.md Outdated Show resolved Hide resolved
@ckerr
Copy link
Member

ckerr commented Mar 21, 2019

This is good stuff and I like it. Do we also want a warning to go with it? Happy to write one.

@felixrieseberg is there a reliable way of knowing whether the app can load untrusted content? If so, then yes.

@miniak miniak force-pushed the miniak/docs-security-remote branch from da31786 to 876e56d Compare March 25, 2019 17:32
@miniak miniak marked this pull request as ready for review March 25, 2019 17:36
@miniak miniak requested a review from a team March 25, 2019 17:40
@miniak
Copy link
Contributor Author

miniak commented Mar 25, 2019 •
edited

This is good stuff and I like it. Do we also want a warning to go with it? Happy to write one.

@felixrieseberg I would appreciate if you could do that!

nornagon
nornagon reviewed Mar 29, 2019
View reviewed changes
docs/tutorial/security.md Outdated Show resolved Hide resolved
docs/tutorial/security.md Outdated Show resolved Hide resolved
docs/tutorial/security.md Outdated Show resolved Hide resolved
docs/tutorial/security.md Outdated Show resolved Hide resolved
@miniak miniak force-pushed the miniak/docs-security-remote branch from 6a3d4d1 to f5a70b2 Compare March 30, 2019 08:37
@miniak miniak requested review from ckerr and nornagon March 30, 2019 08:38
felixrieseberg
felixrieseberg approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@felixrieseberg felixrieseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it a read, I think this is now a good improvement 👍

nornagon
nornagon reviewed Apr 4, 2019
View reviewed changes
docs/tutorial/security.md Outdated Show resolved Hide resolved
@ppontes ppontes force-pushed the miniak/docs-security-remote branch from 2ade1a0 to ffb9c87 Compare April 4, 2019 20:23
@miniak
Copy link
Contributor Author

miniak commented Apr 5, 2019

@zcbenz, @deepak1556 can you also please have a look?

deepak1556
deepak1556 approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexeykuzmin alexeykuzmin merged commit 235eea6 into master Apr 5, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 5, 2019

No Release Notes

@alexeykuzmin alexeykuzmin deleted the miniak/docs-security-remote branch April 5, 2019 18:41
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@miniak @kiku-jw
docs: add remote module to docs/tutorial/security.md (electron#17480)
be4f2a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppontes ppontes ppontes left review comments

@nornagon nornagon nornagon approved these changes

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@felixrieseberg felixrieseberg felixrieseberg approved these changes

@ckerr ckerr Awaiting requested review from ckerr

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@miniak @felixrieseberg @ckerr @nornagon @alexeykuzmin @deepak1556 @ppontes