Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use a more unique identifier for NSUserNotification instances (backport: 4-1-x) #17483

Merged
merged 1 commit into from Mar 20, 2019
Merged

fix: use a more unique identifier for NSUserNotification instances (backport: 4-1-x) #17483

merged 1 commit into from Mar 20, 2019

Commits on Mar 20, 2019

  1. fix: use a more unique identifier for NSUserNotification instances 

    So although apple has it documented that notifications with duplicate identifiers in the same session won't be presented.  They apparently forgot to mention that macOS also non-deterministically and without any errors, logs or warnings will also not present some notifications in future sessions if they have a previously used identifier.

As such, we're going to truly randomize these identifiers so they are
unique between apps and sessions.  The identifier now consists of a
randomly generated UUID and the app bundle id.
    @MarshallOfSound @electron-bot
    MarshallOfSound authored and electron-bot committed Mar 20, 2019
    Copy the full SHA
    3f5b037 View commit details
    Browse the repository at this point in the history