Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: strip trailing whitespace in docs #17488

Merged
merged 1 commit into from Mar 20, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Mar 20, 2019

Description of Change

Trailing whitespace is evil. Added npm run lint:check-trailing-whitespace linter step.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak self-assigned this Mar 20, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 20, 2019
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way we can add linting for this in our lint.js script. I agree whitespace like this just annoys me 😆

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to approve

@miniak miniak force-pushed the miniak/strip-trailing-whitespace branch from d988081 to 85adacd Compare March 20, 2019 19:16
@miniak
Copy link
Contributor Author

miniak commented Mar 20, 2019

@MarshallOfSound added npm run lint:check-trailing-whitespace, which is part of npm run lint:docs

@miniak
Copy link
Contributor Author

miniak commented Mar 20, 2019

it works! :)

> electron@6.0.0-nightly.20190311 lint:check-trailing-whitespace /home/builduser/project/src/electron
> python ./script/check-trailing-whitespace.py

Parsed through 182 files within docs directory and its 6 subdirectories.
Found 0 files with trailing whitespace.

@@ -86,6 +86,7 @@ auto_filenames = {
"docs/api/structures/notification-action.md",
"docs/api/structures/point.md",
"docs/api/structures/printer-info.md",
"docs/api/structures/process-memory-info.md",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@ppontes ppontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@MarshallOfSound MarshallOfSound changed the title chore: strip trailing whitespace in docs build: strip trailing whitespace in docs Mar 20, 2019
@MarshallOfSound MarshallOfSound removed the new-pr 🌱 PR opened in the last 24 hours label Mar 20, 2019
@MarshallOfSound MarshallOfSound merged commit a82bbd0 into master Mar 20, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 20, 2019

No Release Notes

@miniak miniak deleted the miniak/strip-trailing-whitespace branch March 22, 2019 06:52
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants