chore: update to chromium 75.0.3740.3 #17507

nornagon · 2019-03-21T22:15:44Z

BREAKING CHANGE: Upgraded to Chromium 75.

Notes: Upgraded to Chromium 75.

FIXME:

IsNearDeath is removed from upstream --> 73d7119

Requires Review:

~~enable_file_url_support can no longer be enabled by embedders: b1da14c~~ Dealt with 796426a

deepak1556 · 2019-03-22T06:53:49Z

the sdk change commit and fix: ScopedBlockingCall now takes a location for tracing information , should have already made it through #17345 , wonder why the github ui doesn't show conflicts 😕

deepak1556 · 2019-03-22T10:58:11Z

Another important change that went in this release is that windows builds switched to chromiums libc++ https://bugs.chromium.org/p/chromium/issues/detail?id=801780 , https://docs.google.com/document/d/1VPxepzuyWbXFzv1VpkSKEn0wPvSUffpcaOLislhcwrA/edit#heading=h.4r33ra48xro (check the design document). I think we should investigate the impact of this change.

Unsurprisingly the build errors are related to this :)

/cc @zcbenz

deepak1556 · 2019-03-22T11:00:56Z

@jkleinsc can we enable windows debug builds for the upgrade branches ?

zcbenz · 2019-03-25T07:46:21Z

Another important change that went in this release is that windows builds switched to chromiums libc++

Native node modules may be affected, but I think we should be fine since the runtime library is linked dynamically in native modules.

jkleinsc · 2019-03-25T14:35:27Z

@deepak, I kicked off Windows debug builds

nornagon · 2019-03-25T19:48:00Z

Native node modules may be affected, but I think we should be fine since the runtime library is linked dynamically in native modules.

I don't think this is true any more. See e.g. #16228, #14617

The design doc says:

Embedders that want to keep using Visual Studio’s C++ library can set use_custom_libcxx = false. This configuration will become community-supported, meaning we’ll accept patches to keep it working but won’t have bots for it.

and:

libc++ is not ABI-compatible with msstl, so projects embedding Chromium (like CEF) and exposing a C++ standard library objects in their API would require either that their embedders use libc++, or they’d have to keep Chromium buildable with the MS STL.

I think we should probably go with use_custom_libcxx = false on Windows.

MarshallOfSound · 2019-03-25T20:10:24Z

I think we should probably go with use_custom_libcxx = false on Windows.

I agree, I'm getting a Windows VM set up at the moment so I'll give this a spin shortly 👍

KoenLav · 2019-03-26T22:32:11Z

@nornagon @MarshallOfSound please forgive my ignorance, but why stick with the "non-standard"/community supported route?

nornagon · 2019-03-26T22:45:12Z

@KoenLav because of node native modules.

node native modules don't expect to be built against libc++ on windows & such may not compile. Additionally, we'd have to ship libc++'s headers with the electron header bundle and upstream changes to node-gyp and cmake-js to link against libc++ instead of msstl.

it's a complicated situation with no great answers. sticking with msstl is the easiest option in the short term, but we may have to figure out something else in the long run.

https://chromium-review.googlesource.com/c/chromium/src/+/1519726

https://chromium-review.googlesource.com/c/chromium/src/+/1491812

data URLs are _always_ enabled in the network service now and this is enforced in the Content layer. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1512337

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1492042

removed Unsure how the change in default of file_url_support affects us Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1512337

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1531481

…tocol NOLINT disables the linting error that we can't fix because its just implementing a content API. We also disable clang-format because it tries to format the // NOLINT onto a new line which doesn't exactly work

Just a rename Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1509795

Adds a patch that reverts https://chromium-review.googlesource.com/c/v8/v8/+/1526195 in order to let native modules build. nan has a strong dependency on the IsNearDeath method. This needs to be solved upstream in nan or V8.

…CHECK

…removed

deepak1556

LGTM, couple of questions.

atom/browser/atom_browser_client.cc

patches/common/chromium/command-ismediakey.patch

patches/common/chromium/fix_retain_compatibility_with_msvc.patch

atom/browser/notifications/platform_notification_service.cc

MarshallOfSound

Blocking on #17507 (comment)

MarshallOfSound

All set 👍

nornagon · 2019-04-03T19:54:03Z

atom/browser/ui/inspectable_web_contents_impl.cc

@@ -738,7 +739,8 @@ void InspectableWebContentsImpl::DispatchProtocolMessage(
  if (message.length() < kMaxMessageChunkSize) {
    base::string16 javascript =
        base::UTF8ToUTF16("DevToolsAPI.dispatchMessage(" + message + ");");


lol really, we don't escape this string at all?

nornagon · 2019-04-03T19:54:58Z

build/zip.py

@@ -52,7 +52,7 @@ def main(argv):
  if sys.platform == 'darwin':
    execute(['zip', '-r', '-y', dist_zip] + list(dist_files))
  else:
-    with zipfile.ZipFile(dist_zip, 'w', zipfile.ZIP_DEFLATED) as z:
+    with zipfile.ZipFile(dist_zip, 'w', zipfile.ZIP_DEFLATED, True) as z:


Suggested change

with zipfile.ZipFile(dist_zip, 'w', zipfile.ZIP_DEFLATED, True) as z:

with zipfile.ZipFile(dist_zip, 'w', zipfile.ZIP_DEFLATED, allowZip64=True) as z:

nornagon · 2019-04-03T19:56:08Z

patches/common/chromium/disable_custom_libcxx_on_windows.patch

+       is_fuchsia || is_android || is_mac ||
+-      (is_win && is_clang && !use_libfuzzer) ||
+      # Do not use custom libcxx on windows
+      # (is_win && is_clang && !use_libfuzzer) ||


i'd recommend adding && !is_electron here rather than commenting out.

nornagon

lgtm!

release-clerk · 2019-04-03T20:17:40Z

Release Notes Persisted

Upgraded to Chromium 75.

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 21, 2019

MarshallOfSound marked this pull request as ready for review March 22, 2019 07:01

MarshallOfSound requested a review from a team as a code owner March 22, 2019 07:01

MarshallOfSound force-pushed the chromium-upgrade/75 branch from b05bd93 to 276087d Compare March 22, 2019 07:12

MarshallOfSound mentioned this pull request Mar 22, 2019

chore: bump chromium to 74.0.3729.30 (master) #17514

Closed

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 22, 2019

MarshallOfSound force-pushed the chromium-upgrade/75 branch from 905c4f9 to f20d4ee Compare March 29, 2019 00:11

nornagon and others added 14 commits April 2, 2019 14:43

chore: update to chromium 75.0.3740.3

7116c10

update boringssl patches

0f990c3

update chromium patches

2dc4222

download gn from cipd instead of GCS

9cc4cb2

https://chromium-review.googlesource.com/c/chromium/src/+/1519726

fixup! download gn from cipd instead of GCS

e2f0852

fixup! download gn from cipd instead of GCS

9819433

add //ui/base/idle dep

47d5f9f

add extra arguments to HandleExternalProtocol

e44b526

https://chromium-review.googlesource.com/c/chromium/src/+/1491812

build: update circle base image and mac docs for 10.13 SDK

50b9933

chore: update permission_status.h include for new path

406ceaa

fix: remove enable_data_url_support from OnNetworkServiceCreated

2bf740d

data URLs are _always_ enabled in the network service now and this is enforced in the Content layer. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1512337

fix: RFH->ExecuteJavascript now requires a callback

f95de3d

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1492042

fix: enable_file_url_support and enable_data_url_support have been

ab92cfd

removed Unsure how the change in default of file_url_support affects us Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1512337

fix: ViewHierarchyChangedDetails moved to the views namespace

74ac80e

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1531481

MarshallOfSound and others added 16 commits April 2, 2019 14:43

fix: base::LaunchOptions environ is now environment

04a8b9f

Just a rename Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1509795

fixme: IsNearDeath has been removed upstream

ab66c4b

Adds a patch that reverts https://chromium-review.googlesource.com/c/v8/v8/+/1526195 in order to let native modules build. nan has a strong dependency on the IsNearDeath method. This needs to be solved upstream in nan or V8.

fix: _ASSERT is not defined anymore, the appropriate replacement is D…

90a738a

…CHECK

chore: replace DCHECK(a > b) with DCHECK_GT

b965abf

fixup! enable_file_url_support and enable_data_url_support have been …

515c927

…removed

build: allow zip files to be created larger than 2GB

30448bb

chore: make DCHECK available in win7 toast impl

0fd0b3f

chore: include what we use, cmath in toast.cc

43dc4e8

fix: use default constructor for NotificationData struct

e352d73

don't copy in make_shared in win32_desktop_notifications

7e9a271

build: disable the custom libcxx on Windows

fe06784

build: do not use custom libcxx on windows

a34c47b

chore: enable_data_url_support does not exist anymore

2fda0bd

chore: disable custom libcxx on windows

d1a7b42

chore: add patch to fix MSVC++ incompatibilty on Windows

63d6be0

MarshallOfSound force-pushed the chromium-upgrade/75 branch from 2a37635 to 63d6be0 Compare April 2, 2019 21:43

build: force a windows CI run

76d584c

jkleinsc approved these changes Apr 3, 2019

View reviewed changes

deepak1556 reviewed Apr 3, 2019

View reviewed changes

MarshallOfSound requested changes Apr 3, 2019

View reviewed changes

chore: fixup ismediakey patch for lost changes

a65f242

MarshallOfSound approved these changes Apr 3, 2019

View reviewed changes

nornagon commented Apr 3, 2019

View reviewed changes

MarshallOfSound merged commit 5d45b59 into master Apr 3, 2019

MarshallOfSound deleted the chromium-upgrade/75 branch April 3, 2019 20:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update to chromium 75.0.3740.3 #17507

chore: update to chromium 75.0.3740.3 #17507

nornagon commented Mar 21, 2019 •

edited by MarshallOfSound

deepak1556 commented Mar 22, 2019

deepak1556 commented Mar 22, 2019 •

edited

deepak1556 commented Mar 22, 2019 •

edited

zcbenz commented Mar 25, 2019

jkleinsc commented Mar 25, 2019

nornagon commented Mar 25, 2019 •

edited

MarshallOfSound commented Mar 25, 2019

KoenLav commented Mar 26, 2019

nornagon commented Mar 26, 2019

deepak1556 left a comment

MarshallOfSound left a comment

MarshallOfSound left a comment

nornagon Apr 3, 2019

nornagon Apr 3, 2019

nornagon Apr 3, 2019

nornagon left a comment

release-clerk bot commented Apr 3, 2019

	with zipfile.ZipFile(dist_zip, 'w', zipfile.ZIP_DEFLATED, True) as z:
	with zipfile.ZipFile(dist_zip, 'w', zipfile.ZIP_DEFLATED, allowZip64=True) as z:

chore: update to chromium 75.0.3740.3 #17507

chore: update to chromium 75.0.3740.3 #17507

Conversation

nornagon commented Mar 21, 2019 • edited by MarshallOfSound

FIXME:

Requires Review:

deepak1556 commented Mar 22, 2019

deepak1556 commented Mar 22, 2019 • edited

deepak1556 commented Mar 22, 2019 • edited

zcbenz commented Mar 25, 2019

jkleinsc commented Mar 25, 2019

nornagon commented Mar 25, 2019 • edited

MarshallOfSound commented Mar 25, 2019

KoenLav commented Mar 26, 2019

nornagon commented Mar 26, 2019

deepak1556 left a comment

Choose a reason for hiding this comment

MarshallOfSound left a comment

Choose a reason for hiding this comment

MarshallOfSound left a comment

Choose a reason for hiding this comment

nornagon Apr 3, 2019

Choose a reason for hiding this comment

nornagon Apr 3, 2019

Choose a reason for hiding this comment

nornagon Apr 3, 2019

Choose a reason for hiding this comment

nornagon left a comment

Choose a reason for hiding this comment

release-clerk bot commented Apr 3, 2019

nornagon commented Mar 21, 2019 •

edited by MarshallOfSound

deepak1556 commented Mar 22, 2019 •

edited

deepak1556 commented Mar 22, 2019 •

edited

nornagon commented Mar 25, 2019 •

edited