fix: set default_id and cancel_id correctly on confirm dialogs

[MarshallOfSound]

Description of Change

Sets cancel_id to the Cancel button and default_id to the OK button in CONFIRM type dialogs. (window.confirm)

Fixes #17502

Release Notes

Notes: Fixed the handling of the escape key in dialogs created by window.confirm. The "Cancel" button is now triggered by the escape key, and the "OK" button is now triggered by the return key.

[ckerr]

LGTM

[release-clerk]

Release Notes Persisted

Fixed the handling of the escape key in dialogs created by window.confirm. The "Cancel" button is now triggered by the escape key, and the "OK" button is now triggered by the return key.

[trop]

I have automatically backported this PR to "5-0-x", please check out #17578

[jsteiner]

@MarshallOfSound would it be possible to backport this to 4.x? Seems worth it given the potential consequences of wrongly confirming something.

[MarshallOfSound]

@jsteiner I don't think 4.x has this bug and can't verify rn. Can you repro for 4?

[jsteiner]

@MarshallOfSound yeah, we're seeing this issue on 4.0.1. It does seem to have the same hardcoded line of code on the 4-1-x branch here: https://github.com/electron/electron/blob/4-1-x/atom/browser/atom_javascript_dialog_manager.cc#L79