Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle a race condition between preload scripts executing and navigations (backport: 4-1-x) #17596

Merged
merged 1 commit into from Mar 28, 2019
Merged

fix: handle a race condition between preload scripts executing and navigations (backport: 4-1-x) #17596

merged 1 commit into from Mar 28, 2019
+3 −0

Commits on Mar 28, 2019

  1. fix: handle a race condition between preload scripts executing and na… 

    …vigations

There is a race condition between DidCreateScriptContext and another
navigation occuring in the main process. If the navigation occurs while
the preload script is running, the same process is re-used.  This
ensures that any pending navigations are completely removed / ignored
when we trigger a new navigation.

Fixes electron#17576
    @MarshallOfSound @electron-bot
    MarshallOfSound authored and electron-bot committed Mar 28, 2019
    1
    Copy the full SHA
    b90ca47 View commit details
    Browse the repository at this point in the history