fix: emit process 'loaded' event in sandboxed renderers #17680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppontes
approved these changes
Apr 3, 2019
miniak
force-pushed
the
miniak/process-loaded-sandbox
branch
from
e1b074a
to
3951969
Compare
MarshallOfSound
approved these changes
Apr 3, 2019
|
Release Notes Persisted
|
This was referenced Apr 16, 2019
miniak
changed the title
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Makes it consistent with non-sandboxed renderer behavior.
Checklist
npm testpassesRelease Notes
Notes: Fixed
'loaded'event not being emitted in sandboxed renderers.