docs: update nodeIntegration section for new defaults #17715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/docs-security-node-integration
branch
from
5567775
to
58b1027
Compare
MarshallOfSound
previously requested changes
Apr 6, 2019
miniak
force-pushed
the
miniak/docs-security-node-integration
branch
from
58b1027
to
c72fd2d
Compare
|
related: electron/electronjs.org-old#1702 |
miniak
force-pushed
the
miniak/docs-security-node-integration
branch
from
c72fd2d
to
22c3fc2
Compare
|
@MarshallOfSound now that 5.0.0 has been released, should we merge it? |
malept
suggested changes
Apr 27, 2019
Co-Authored-By: miniak <milan.burda@gmail.com>
malept
approved these changes
Apr 29, 2019
codebytere
approved these changes
Apr 29, 2019
|
No Release Notes |
|
I was unable to backport this PR to "5-0-x" cleanly; |
|
I have automatically backported this PR to "6-0-x", please check out #18047 |
|
@miniak can you manually bp this to |
4 tasks
|
A maintainer has manually backported this PR to "5-0-x", please check out #18051 |
|
@codebytere backported manually |
4 tasks
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Follow up to chore: disable nodeIntegration / webviewTag by default #16235
Checklist
npm testpassesRelease Notes
Notes: no-notes
/cc @electron/wg-security