Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support for the new Japanese Era (Reiwa) to ICU #17833

Merged

Commits on Apr 15, 2019

  1. fix: Add support for the new Japanese Era (Reiwa) to ICU

    This change backports changes from the upstream ICU project's
    maintenance release for ICU 62.2 in order to enable support for the new
    Japanese Era "Reiwa" in Chromium 69 (which uses ICU version 62.1).
    
    Upstream release: http://site.icu-project.org/download/62
    
    Additionally, this change also includes the following fixes/updates:
     - Update IANA time zone tzdata to 2019a.
     - Japanese calendar era calculation should use local time, not UTC.
     - Japanese calendar: use all valid eras for calendar calculations.
     - Fix LocalMemory move constructor delete issue.
    
    This change requires re-generating the checked-in Chromium ICU data
    files (ex: icudtl.dat) in order for them to have the updated data for
    the new era name. However, that will be done with a separate commit in
    order to make the ".patch" files cleaner.
    
    Note: All of the checked-in files are be regenerated, even though
    the Electron project only uses the "common" one.
    
    Also included in this change are some minor changes to the scripts used
    by Chromium for building the data files so that they actually work on
    Ubuntu.
    jefgen committed Apr 15, 2019
    Copy the full SHA
    682608b View commit details
    Browse the repository at this point in the history