Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy pixels in AddImageSkiaRepFromBuffer #17843

Merged
merged 1 commit into from Apr 18, 2019
Merged

fix: copy pixels in AddImageSkiaRepFromBuffer #17843

merged 1 commit into from Apr 18, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Apr 17, 2019 •
edited

Description of Change

Changing buffer data should not modify the nativeImage pixels, makes it consistent with PNG / JPEG behavior, which always copies the data.

Checklist

Release Notes

Notes: Fixed inconsistent behavior where modifying the buffer would change nativeImage pixels, while decoded PNG / JPEG data is a copy.

@miniak miniak self-assigned this Apr 17, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 17, 2019
@miniak miniak mentioned this pull request Apr 17, 2019
Merged
3 tasks
@miniak miniak requested a review from deepak1556 April 17, 2019 18:48
@zcbenz zcbenz merged commit 5e7c828 into master Apr 18, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 18, 2019

Release Notes Persisted

Fixed inconsistent behavior where modifying the buffer would change nativeImage pixels, while decoded PNG / JPEG data is a copy.

@zcbenz zcbenz deleted the miniak/native-image branch April 18, 2019 00:16
@trop
Copy link
Contributor

trop bot commented Apr 18, 2019

I was unable to backport this PR to "3-1-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 18, 2019

I was unable to backport this PR to "4-1-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 18, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@miniak
Copy link
Contributor Author

miniak commented Apr 18, 2019

/trop run backport-to 5-0-x

@trop
Copy link
Contributor

trop bot commented Apr 18, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Apr 18, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

miniak added a commit that referenced this pull request Apr 18, 2019
@miniak
fix: copy pixels in AddImageSkiaRepFromBuffer (#17843)
41ce182
miniak added a commit that referenced this pull request Apr 18, 2019
@miniak
fix: copy pixels in AddImageSkiaRepFromBuffer (#17843)
c9f2e28
miniak added a commit that referenced this pull request Apr 18, 2019
@miniak
fix: copy pixels in AddImageSkiaRepFromBuffer (#17843)
09d6e5c
This was referenced Apr 18, 2019
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Apr 18, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #17863

@trop trop bot added the in-flight/5-0-x label Apr 18, 2019
@trop
Copy link
Contributor

trop bot commented Apr 18, 2019

A maintainer has manually backported this PR to "4-1-x", please check out #17862

@trop trop bot added the in-flight/4-1-x label Apr 18, 2019
@trop
Copy link
Contributor

trop bot commented Apr 18, 2019

A maintainer has manually backported this PR to "3-1-x", please check out #17861

@trop trop bot added the in-flight/3-1-x label Apr 18, 2019
codebytere pushed a commit that referenced this pull request Apr 18, 2019
@miniak @codebytere
fix: copy pixels in AddImageSkiaRepFromBuffer (#17843) (#17862)
2360f3e
codebytere pushed a commit that referenced this pull request Apr 18, 2019
@miniak @codebytere
fix: copy pixels in AddImageSkiaRepFromBuffer (#17843) (#17863)
321e66d
codebytere pushed a commit that referenced this pull request Apr 18, 2019
@miniak @codebytere
fix: copy pixels in AddImageSkiaRepFromBuffer (#17843) (#17861)
276ebca
@sofianguy sofianguy added this to Fixed in 5.0.0-beta.9 in 5.0.x Apr 20, 2019
@sofianguy sofianguy added this to Fixed (3.1.9) in 3.0.x / 3.1.x May 1, 2019
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@miniak @kiku-jw
fix: copy pixels in AddImageSkiaRepFromBuffer (electron#17843)
d98fb32
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees

@miniak miniak

Labels
None yet
Projects
No open projects
3.0.x / 3.1.x
Fixed (3.1.9)
5.0.x
Fixed in 5.0.0-beta.9
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @nornagon @zcbenz @codebytere