chore: show underlying stack in errors in remote module #17851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
approved these changes
Apr 18, 2019
codebytere
approved these changes
Apr 18, 2019
nornagon
changed the title
|
Release Notes Persisted
|
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When calling a remote method throws an error, the remote module returns the underlying error's message, but not the stack information, which is useful for debugging. This adds the stack info to the error message.
Checklist
npm testpassesRelease Notes
Notes: Added additional error information to errors thrown when using the
remotemodule.