Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash when run from SMB network share #17886

Merged
merged 1 commit into from Apr 23, 2019
Merged

fix: crash when run from SMB network share #17886

merged 1 commit into from Apr 23, 2019

Conversation

codebytere
Copy link
Member

Description of Change

Resolves #16855.

Safely handles failure of initWithNibNamed on SMB shares by falling back to contents of different nibfile.

cc @nornagon

Checklist

Release Notes

Notes: Fixed crash when Electron run from SMB network share.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 19, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 20, 2019
@codebytere codebytere merged commit 316abe2 into master Apr 23, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 23, 2019

Release Notes Persisted

Fixed crash when Electron run from SMB network share.

@codebytere codebytere deleted the fix-smb-crash branch April 23, 2019 02:28
@trop
Copy link
Contributor

trop bot commented Apr 23, 2019

I was unable to backport this PR to "3-1-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 23, 2019

I was unable to backport this PR to "4-1-x" cleanly;
you will need to perform this backport manually.

This was referenced Apr 23, 2019
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Apr 23, 2019

I have automatically backported this PR to "5-0-x", please check out #17908

@trop trop bot removed the target/4-1-x label Apr 23, 2019
@trop
Copy link
Contributor

trop bot commented Apr 23, 2019

I have automatically backported this PR to "6-0-x", please check out #17909

@sofianguy sofianguy added this to Fixed in 5.0.1 in 5.0.x May 4, 2019
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
fix: crash when run from SMB network share (electron#17886)
4714b36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.1
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on macOS when run from SMB network share
2 participants
@codebytere @MarshallOfSound