Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update breaking changes on webFrame.setSpellCheckProvider #17915

Merged
merged 5 commits into from Jun 3, 2019

Conversation

magne4000
Copy link
Contributor

Description of Change

PR #14032 introduced breaking changes around webFrame.setSpellCheckProvider API, but those are not mentioned inside breaking-changes.md

Checklist

Release Notes

notes: webFrame.setSpellCheckProvider breaking change documented

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Apr 23, 2019
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Apr 23, 2019
ckerr and others added 2 commits April 29, 2019 13:24
@codebytere codebytere changed the title doc: Update breaking changes on webFrame.setSpellCheckProvider docs: Update breaking changes on webFrame.setSpellCheckProvider May 2, 2019
@ckerr ckerr merged commit fd9e031 into electron:master Jun 3, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 3, 2019

No Release Notes

@welcome
Copy link

welcome bot commented Jun 3, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@magne4000 magne4000 deleted the doc/breaking-changes branch June 4, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants