Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: revert disabling Vulkan support (4-1-x) #17987

Merged
merged 1 commit into from Apr 30, 2019
Merged

build: revert disabling Vulkan support (4-1-x) #17987

merged 1 commit into from Apr 30, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Apr 26, 2019

Description of Change

Reverts #17789, the correct way to fix the issue is #17985.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak requested review from nornagon and alexeykuzmin and removed request for nornagon April 26, 2019 16:05
@miniak miniak self-assigned this Apr 26, 2019
@miniak miniak requested a review from nornagon April 26, 2019 16:10
@miniak miniak added 4-2-x backport This is a backport PR labels Apr 29, 2019
@jkleinsc jkleinsc merged commit 2f67cd5 into 4-1-x Apr 30, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 30, 2019

No Release Notes

@jkleinsc jkleinsc deleted the miniak/revert-disable-vulkan-4-1-x branch April 30, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees

@miniak miniak

Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @alexeykuzmin @jkleinsc