fix: explicitly focus window on win.show()

[codebytere]

Description of Change

Fixes #18034.

Our documentation for win.show says that this explicitly gives the window focus, and on macOS we implement Show with unhide and so this rings true.

However, this is not true on Windows, which is implemented in NativeWindowViews. This PR fixes that issue by explicitly focusing the window with widget()->Activate().

cc @MarshallOfSound @deepak1556 @zcbenz

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed an issue on Windows where calling .show() on a BrowserWindow did not focus the window.

[release-clerk]

Release Notes Persisted

Fixed an issue on Windows where calling .show() on a BrowserWindow did not focus the window.

[trop]

I have automatically backported this PR to "4-1-x", please check out #18079

[trop]

I have automatically backported this PR to "5-0-x", please check out #18080

[trop]

I have automatically backported this PR to "6-0-x", please check out #18081

[jwheare]

Does this fix #2867?

[jwheare]

I've now tested, and this doesn't fix #2867, see comments there for my workaround.

[softremake]

I've now tested, and this doesn't fix #2867, see comments there for my workaround.

Thanks @jwheare
However I've tried remote.app.emit('activate'); in electron 5 and it didn't help...
I'm using nodemon and I want to see the main window after changing source code, but on Windows 10 the only thing I could find working is setting alwaysOnTop = true on window creation and then use setAlwaysOnTop(false) after page is rendered (through IPC)...

[jwheare]

@softremake ah that’s just a custom event I listen to in the main process to show and focus the main window https://github.com/irccloud/irccloud-desktop/blob/694923a20efd42bcc09943c8167c8fcffb3f0a01/app/main.js#L211

[liuyike98]

still have the problem in electron 16.0.2, when i hide a window, then from main process call show(), still loss focus.tried many methods, still doesn't work