fix: fs.promises does not work with ASAR paths #18092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 1, 2019
miniak
force-pushed
the
miniak/asar-fs-promises
branch
3 times, most recently
from
46b0047
to
7d21b45
Compare
codebytere
approved these changes
May 1, 2019
There was a problem hiding this comment.
lgtm but second opinion from @MarshallOfSound?
ideally we'd wrap the actual methods instead of util.promisifying them but that'd add a lot of code overhead so i feel comfortable with this approach as it stands
miniak
force-pushed
the
miniak/asar-fs-promises
branch
2 times, most recently
from
4d2e23c
to
d112ffd
Compare
|
@MarshallOfSound test added |
miniak
force-pushed
the
miniak/asar-fs-promises
branch
from
d112ffd
to
d9b774a
Compare
|
@zcbenz can you have a look, please? |
alexeykuzmin
approved these changes
May 2, 2019
zcbenz
approved these changes
May 2, 2019
|
Release Notes Persisted
|
This was referenced May 2, 2019
|
I have automatically backported this PR to "5-0-x", please check out #18115 |
|
I have automatically backported this PR to "6-0-x", please check out #18114 |
|
@miniak this should probably also go to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #17190.
Added missing overrides for
fs.promisesAPIs implementing ASAR support. Related to #17999.Checklist
npm testpassesRelease Notes
Notes: Fixed
fs.promisesAPIs not working with ASAR paths.