New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not mark navigations interupted with same-document navigations as aborted #18109
Conversation
Can you add a spec based on the issue sample. Thanks! |
Also please consider making |
dbc93e6
to
91e6985
Compare
Release Notes Persisted
|
I have automatically backported this PR to "5-0-x", please check out #18142 |
I have automatically backported this PR to "6-0-x", please check out #18143 |
…s as aborted (electron#18109) * fix: do not mark navigations interupted with same-document navigations as aborted * spec: add tests for the loadURL promise
Fixes #17526
This is probably the closest thing we can get to something that makes everyone happy. Virtual navigations are now ignored, actually interrupting the
loadURL
call with anotherloadURL
call still correctly rejects the first promise.Notes: Fixed case where the promise returned by
loadURL
andloadFile
would be rejected withERR_ABORTED
if you triggered a virtual navigation before the page had finished loading. E.g. Usedhistory.pushState
or setlocation.hash