Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash on systemPreferences.getAccentColor() #18144

Merged
merged 1 commit into from May 7, 2019
Merged

fix: crash on systemPreferences.getAccentColor() #18144

merged 1 commit into from May 7, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented May 4, 2019 •
edited

Description of Change

Closes #18140.

Fixes a crash in systemPreferences.getAccentColor() by properly implementing hexadecimalValue on NSColor instead of using a helper that doesn't account for potential nullptrs.

cc @MarshallOfSound

Checklist

Release Notes

Notes: Fixed a crash in systemPreferences.getAccentColor().

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 4, 2019
@codebytere codebytere force-pushed the fix-accenctolor-crash branch 3 times, most recently from 05024de to bdff1c9 Compare May 4, 2019 03:34
miniak
miniak requested changes May 4, 2019
View reviewed changes
atom/browser/ui/cocoa/NSColor+Hex.mm Outdated Show resolved Hide resolved
atom/browser/ui/cocoa/NSColor+Hex.h Show resolved Hide resolved
atom/browser/ui/cocoa/NSColor+Hex.mm Outdated Show resolved Hide resolved
atom/browser/ui/cocoa/NSColor+Hex.mm Show resolved Hide resolved
atom/browser/ui/cocoa/NSColor+Hex.mm Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 5, 2019
@codebytere codebytere requested a review from miniak May 6, 2019 15:23
@codebytere codebytere merged commit 0ab3d7a into master May 7, 2019
@release-clerk
Copy link

release-clerk bot commented May 7, 2019

Release Notes Persisted

Fixed a crash in systemPreferences.getAccentColor().

@codebytere codebytere deleted the fix-accenctolor-crash branch May 7, 2019 15:26
@trop
Copy link
Contributor

trop bot commented May 7, 2019

I have automatically backported this PR to "5-0-x", please check out #18194

@trop trop bot mentioned this pull request May 7, 2019
Merged
@trop trop bot mentioned this pull request May 7, 2019
Merged
@trop
Copy link
Contributor

trop bot commented May 7, 2019

I have automatically backported this PR to "6-0-x", please check out #18195

@sofianguy sofianguy added this to Fixed in 6.0.0-beta.2 in 6.1.x May 8, 2019
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
fix: crash on systemPreferences.getAccentColor() (electron#18144)
8e6990b
@sofianguy sofianguy added this to Fixed in 5.0.2 in 5.0.x Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.2
6.1.x
Fixed in 6.0.0-beta.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App crashes after invoking of systemPreferences.getAccentColor()
2 participants
@codebytere @miniak