Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lost window.opener after cross-origin navigation #18173

Merged
merged 7 commits into from Jun 3, 2019
Merged

fix: lost window.opener after cross-origin navigation #18173

merged 7 commits into from Jun 3, 2019

Commits on Jun 1, 2019

  1. Get a site instance related to current one instead of creation a new one 

    Using `GetRelatedSiteInstance` will keep the relation (same browsing instance) between the current and the new site instance.
    @alexstrat
    alexstrat committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    f3de585 View commit details
    Browse the repository at this point in the history

  2. Some relies on preloads in opened window 

    The fact that, now, we always have an opener for opened windows diables note integration in opened windows, except if `nodeIntegrationInSubFrames` is enabled.
    @alexstrat
    alexstrat committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    e239973 View commit details
    Browse the repository at this point in the history

  3. Add a test on window.opener after cross-orgin navigation

    @alexstrat
    alexstrat committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    48b0c6c View commit details
    Browse the repository at this point in the history

  4. Make sure to unregisterProtocol in tests

    @alexstrat
    alexstrat committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    9dbf9de View commit details
    Browse the repository at this point in the history

  5. Introduc and use a NetworkSandbox for tests

    @alexstrat
    alexstrat committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    4cbbc08 View commit details
    Browse the repository at this point in the history

  6. Modify tests about zoom persistence to properly simulate cross-origin… 

    … navigation
    @alexstrat
    alexstrat committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    1f6bae3 View commit details
    Browse the repository at this point in the history

  7. Revert "Modify tests about zoom persistence to properly simulate cros… 

    …s-origin navigation"

This reverts commit 0a7537f.
    @alexstrat
    alexstrat committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    6b2f4ca View commit details
    Browse the repository at this point in the history