New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 'page-title-updated' event forwarding + documentation #18270
Conversation
19a4e03
to
94657dc
Compare
cc @pushkin- |
e0b6cce
to
7ddf40c
Compare
7ddf40c
to
52713b1
Compare
@miniak Just to clarify, |
Release Notes Persisted
|
I have automatically backported this PR to "5-0-x", please check out #18318 |
I have automatically backported this PR to "6-0-x", please check out #18319 |
I have automatically backported this PR to "4-2-x", please check out #18320 |
Description of Change
Address #18210.
Checklist
npm test
passes(https://github.com/electron/electron/blob/master/docs/development/testing.md)
Release Notes
Notes: Added missing
'page-title-updated'
event onwebContents
to documentation. Also fixed forwarding of theexplicitSet
argument when emitted onBrowserWindow
.