Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'page-title-updated' event forwarding + documentation #18270

Merged
merged 1 commit into from May 16, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented May 12, 2019

Description of Change

Address #18210.

Checklist

Release Notes

Notes: Added missing 'page-title-updated' event on webContents to documentation. Also fixed forwarding of the explicitSet argument when emitted on BrowserWindow.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 12, 2019
@miniak miniak self-assigned this May 12, 2019
@miniak miniak force-pushed the miniak/page-title-updated branch from 19a4e03 to 94657dc Compare May 12, 2019 16:19
@miniak
Copy link
Contributor Author

miniak commented May 12, 2019

cc @pushkin-

@miniak miniak force-pushed the miniak/page-title-updated branch 2 times, most recently from e0b6cce to 7ddf40c Compare May 12, 2019 16:22
@miniak miniak changed the title docs: add missing 'page-title-updated' event on webContents fix: 'page-title-updated' event forwarding + documentation May 12, 2019
@deepak1556 deepak1556 requested review from zcbenz and a team May 13, 2019 22:46
@miniak miniak force-pushed the miniak/page-title-updated branch from 7ddf40c to 52713b1 Compare May 14, 2019 06:34
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 14, 2019
@pushkin-
Copy link

@miniak Just to clarify, explicitSet is false when navigating to a page that doesn't explicitly set the title via the <title> tag or through Javascript, and it would only ever be false the first time you navigate to a title-less page. All future page-title-updated calls on that page would have explicitSet set to true - is that correct?

@alexeykuzmin alexeykuzmin merged commit 76783e2 into master May 16, 2019
@release-clerk
Copy link

release-clerk bot commented May 16, 2019

Release Notes Persisted

Added missing 'page-title-updated' event on webContents to documentation. Also fixed forwarding of the explicitSet argument when emitted on BrowserWindow.

@alexeykuzmin alexeykuzmin deleted the miniak/page-title-updated branch May 16, 2019 09:33
@trop
Copy link
Contributor

trop bot commented May 16, 2019

I have automatically backported this PR to "5-0-x", please check out #18318

@trop
Copy link
Contributor

trop bot commented May 16, 2019

I have automatically backported this PR to "6-0-x", please check out #18319

@trop
Copy link
Contributor

trop bot commented May 16, 2019

I have automatically backported this PR to "4-2-x", please check out #18320

kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@sofianguy sofianguy added this to Fixed for 6.0.0-beta.4 in 6.1.x May 21, 2019
@sofianguy sofianguy added this to Fixed in 5.0.2 in 5.0.x Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.2
6.1.x
Fixed for 6.0.0-beta.4
Development

Successfully merging this pull request may close these issues.

None yet

6 participants