Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @types/node version for 3-1-x #18283

Merged
merged 1 commit into from Jul 11, 2019
Merged

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented May 13, 2019

Backport of #16174

A direct copy of #18239 just running on first-party CI instead of external-contrib CI

Notes: Update @types/node dependency to a version compatible with Node 10.2.0

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 13, 2019
@trop trop bot mentioned this pull request May 13, 2019
4 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 14, 2019
@shiftkey
Copy link
Contributor

@MarshallOfSound is it worth rebasing and re-running this if #18426 seems to be Working Fine™ to see if it can land?

@MarshallOfSound MarshallOfSound marked this pull request as ready for review June 24, 2019 20:31
@codebytere codebytere merged commit 18e47e7 into 3-1-x Jul 11, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 11, 2019

Release Notes Persisted

Update @types/node dependency to a version compatible with Node 10.2.0

@codebytere codebytere deleted the MarshallOfSound-patch-2 branch July 11, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants