Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default enable_negotiate_port to false (4-2-x) #18287

Merged
merged 2 commits into from May 14, 2019
Merged

fix: default enable_negotiate_port to false (4-2-x) #18287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fa392a
fix: default enable_negotiate_port to false (#18251)
nornagon May 13, 2019
91d8ca2
chore: command_line is not a pointer
MarshallOfSound May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions atom/browser/io_thread.cc
View file
Open in desktop
Expand Up @@ -48,6 +48,8 @@ network::mojom::HttpAuthDynamicParamsPtr CreateHttpAuthDynamicParams(
command_line.GetSwitchValueASCII(switches::kAuthServerWhitelist);
auth_dynamic_params->delegate_whitelist = command_line.GetSwitchValueASCII(
switches::kAuthNegotiateDelegateWhitelist);
auth_dynamic_params->enable_negotiate_port =
command_line.HasSwitch(atom::switches::kEnableAuthNegotiatePort);

return auth_dynamic_params;
}
Expand Down
3 changes: 3 additions & 0 deletions atom/common/options_switches.cc
View file
Open in desktop
Expand Up @@ -247,6 +247,9 @@ const char kAuthServerWhitelist[] = "auth-server-whitelist";
const char kAuthNegotiateDelegateWhitelist[] =
"auth-negotiate-delegate-whitelist";

// If set, include the port in generated Kerberos SPNs.
const char kEnableAuthNegotiatePort[] = "enable-auth-negotiate-port";

} // namespace switches

} // namespace atom
1 change: 1 addition & 0 deletions atom/common/options_switches.h
View file
Open in desktop
Expand Up @@ -118,6 +118,7 @@ extern const char kDiskCacheSize[];
extern const char kIgnoreConnectionsLimit[];
extern const char kAuthServerWhitelist[];
extern const char kAuthNegotiateDelegateWhitelist[];
extern const char kEnableAuthNegotiatePort[];

} // namespace switches

Expand Down