Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate protocol module to NetworkService (Part 7) #18290

Merged
merged 7 commits into from May 14, 2019
Merged

feat: migrate protocol module to NetworkService (Part 7) #18290

merged 7 commits into from May 14, 2019

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented May 14, 2019

Description of Change

Refs #15791.

This PR makes the registerFileProtocol API supporting reading asar files when NetworkService is enabled. The tests of registerFileProtocol are passing now.

Checklist

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 14, 2019
deepak1556
deepak1556 approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the netlog failures is not related.

atom/browser/api/atom_api_protocol_ns.cc
@@ -17,6 +17,10 @@ namespace api {

namespace {

const char* kBuiltinSchemes[] = {
"about", "file", "http", "https", "data", "filesystem",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe using values from url_constants is better, but this is going to be short lived code. Since we plan to remove it once the service is enabled, I am okay with leaving this as it is.

@zcbenz zcbenz merged commit 2ad62ce into master May 14, 2019
@release-clerk
Copy link

release-clerk bot commented May 14, 2019

No Release Notes

@zcbenz zcbenz deleted the ns-protocol-asar branch May 14, 2019 23:30
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@zcbenz @kiku-jw
feat: migrate protocol module to NetworkService (Part 7) (electron#18290
a0e2ff5 
)

* fix: make IsProtocolHandled return true for builtin schemes

* fix: return ERR_NOT_IMPLEMENTED for wrong arg

* Initial work of AsarURLLoader

* Put normal file logics in AsarURLLoader

* Implement asar file reading

* Don't change URL for unpacked file

* Fix cpplint warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @deepak1556