Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: move Windows release builds to AppVeyor cloud #18337

Merged
merged 2 commits into from May 23, 2019

Conversation

jkleinsc
Copy link
Contributor

Description of Change

This PR moves our Windows builds from our self hosted AppVeyor instance to AppVeyor's cloud hosted instance.

Checklist

Release Notes

Notes: no-notes

@zcbenz
Copy link
Member

zcbenz commented May 21, 2019

3-1-x needs manual backport.

@zcbenz
Copy link
Member

zcbenz commented May 21, 2019

This needs approval from @electron/wg-releases .

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We should only make this change to master and then backport once we've successfully triggered and run a nightly release from the master branch. I.e. Let's remove the backport labels for now
  • I don't want to merge this until sudowoodo can handle both windows-ci.electronjs.org and ci.appveyor.com

The sudowoodo files that need updating are:

Let me know if you want help updating sudowoodo

@jkleinsc
Copy link
Contributor Author

@MarshallOfSound corresponding sudowoodo PR here: electron/sudowoodo#120.

I added a new env variable, APPVEYOR_CLOUD_TOKEN so that sudowoodo can run builds on both self hosted AppVeyor and cloud hosted AppVeyor.

@jkleinsc jkleinsc merged commit 842830d into master May 23, 2019
@release-clerk
Copy link

release-clerk bot commented May 23, 2019

No Release Notes

@jkleinsc jkleinsc deleted the move-win-release-builds branch May 23, 2019 20:54
@jkleinsc
Copy link
Contributor Author

jkleinsc commented Jun 3, 2019

/trop run backport-to 6-0-x

@trop
Copy link
Contributor

trop bot commented Jun 3, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "6-0-x" here we go! :D

@jkleinsc
Copy link
Contributor Author

jkleinsc commented Jun 3, 2019

/trop run backport-to 5-0-x

@trop
Copy link
Contributor

trop bot commented Jun 3, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Jun 3, 2019

I have automatically backported this PR to "6-0-x", please check out #18603

@trop trop bot added the in-flight/6-0-x label Jun 3, 2019
@jkleinsc
Copy link
Contributor Author

jkleinsc commented Jun 3, 2019

/trop run backport-to 4-2-x

@trop
Copy link
Contributor

trop bot commented Jun 3, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "4-2-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Jun 3, 2019

I have automatically backported this PR to "5-0-x", please check out #18604

@trop trop bot added the in-flight/5-0-x label Jun 3, 2019
@jkleinsc
Copy link
Contributor Author

jkleinsc commented Jun 3, 2019

/trop run backport-to 3-1-x

@trop
Copy link
Contributor

trop bot commented Jun 3, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "3-1-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Jun 3, 2019

I have automatically backported this PR to "4-2-x", please check out #18605

@trop trop bot added the in-flight/4-2-x label Jun 3, 2019
@trop
Copy link
Contributor

trop bot commented Jun 3, 2019

I was unable to backport this PR to "3-1-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jun 4, 2019

A maintainer has manually backported this PR to "3-1-x", please check out #18627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants