fix: reverse showSaveDialog cancellation bool #18366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Addresses the issue raised in this comment.
The cancellation boolean values were reversed, in that
ShowSaveDialogSync
returnedtrue
if the dialog was not cancelled and we were unilaterally passing it to the completion callback as the canceled value. We also should be returningcanceled
astrue
ifCreateDialogThread
returnedfalse.
This PR thus corrects that error.
cc @miniak
Checklist
npm test
passesRelease Notes
Notes: Corrected a reversal of cancellation values in
showSaveDialog
on the Windows platform.