Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reverse showSaveDialog cancellation bool #18366

Merged
merged 1 commit into from
May 21, 2019
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented May 20, 2019

Description of Change

Addresses the issue raised in this comment.

The cancellation boolean values were reversed, in that ShowSaveDialogSync returned true if the dialog was not cancelled and we were unilaterally passing it to the completion callback as the canceled value. We also should be returning canceled as true if CreateDialogThread returned false.

This PR thus corrects that error.

cc @miniak

Checklist

Release Notes

Notes: Corrected a reversal of cancellation values in showSaveDialog on the Windows platform.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 20, 2019
@codebytere codebytere requested a review from miniak May 20, 2019 15:52
@codebytere codebytere changed the title fix: reverse saveDialog cancellation bool fix: reverse showSaveDialog cancellation bool May 20, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 21, 2019
@ckerr ckerr merged commit e39c76b into master May 21, 2019
@release-clerk
Copy link

release-clerk bot commented May 21, 2019

Release Notes Persisted

Corrected a reversal of cancellation values in showSaveDialog on the Windows platform.

@ckerr ckerr deleted the reverse-cancellation-bool branch May 21, 2019 15:52
@trop
Copy link
Contributor

trop bot commented May 21, 2019

I have automatically backported this PR to "6-0-x", please check out #18383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
6.1.x
Fixed for 6.0.0-beta.4
Development

Successfully merging this pull request may close these issues.

None yet

4 participants