feat: Add option to conditionally disable site instance patches #18396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
target/6-0-x
semver/minor
5 tasks
miniak
reviewed
May 22, 2019
nornagon
reviewed
May 24, 2019
DEPS
Outdated
| @@ -12,7 +12,7 @@ vars = { | |||
| 'chromium_version': | |||
| '84c40395c741fa24ccbd9fc2c5828e2e97472952', | |||
| 'node_version': | |||
| 'a86a4a160dc520c61a602c949a32a1bc4c0fc633', | |||
| 'b213b26f0fb642b95561c0f10039886607036d5a', | |||
There was a problem hiding this comment.
Tis just this commit --> electron/node@dee0db9
MarshallOfSound
force-pushed
the
conditionally-disable-site-instance-patches
branch
from
3901321
to
8c19b11
Compare
deepak1556
reviewed
May 29, 2019
MarshallOfSound
force-pushed
the
conditionally-disable-site-instance-patches
branch
2 times, most recently
from
80e6965
to
90af9bc
Compare
…able of site instance overrides spec: add tests for the new allowRendererProcessReuse property feat: add console warnings / errors for loading non context-aware native modules * Only error if the patch is disabled * Warn all the time, this will ship in Electron 7
MarshallOfSound
force-pushed
the
conditionally-disable-site-instance-patches
branch
from
90af9bc
to
0a952e2
Compare
deepak1556
approved these changes
May 31, 2019
|
Release Notes Persisted
|
|
I was unable to backport this PR to "6-0-x" cleanly; |
MarshallOfSound
added a commit
that referenced
this pull request
May 31, 2019
* chore: allow conditional disable of the site instance override patches at runtime * feat: add app.allowRendererProcessReuse property to allow runtime disable of site instance overrides spec: add tests for the new allowRendererProcessReuse property feat: add console warnings / errors for loading non context-aware native modules * Only error if the patch is disabled * Warn all the time, this will ship in Electron 7
|
A maintainer has manually backported this PR to "6-0-x", please check out #18554 |
MarshallOfSound
added a commit
that referenced
this pull request
Jun 13, 2019
* chore: allow conditional disable of the site instance override patches at runtime * feat: add app.allowRendererProcessReuse property to allow runtime disable of site instance overrides spec: add tests for the new allowRendererProcessReuse property feat: add console warnings / errors for loading non context-aware native modules * Only error if the patch is disabled * Warn all the time, this will ship in Electron 7
MarshallOfSound
added a commit
that referenced
this pull request
Jun 13, 2019
* feat: Add option to conditionally disable site instance patches (#18396) * chore: allow conditional disable of the site instance override patches at runtime * feat: add app.allowRendererProcessReuse property to allow runtime disable of site instance overrides spec: add tests for the new allowRendererProcessReuse property feat: add console warnings / errors for loading non context-aware native modules * Only error if the patch is disabled * Warn all the time, this will ship in Electron 7 * chore: do not warn in about context aware in v6 * chore: update patches
8 tasks
|
app.allowRendererProcessReuse = true ；pall on electron9.0.0 nodejs 12.17.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This adds a new
app.allowRendererProcessReusethat allows us to dynamically (at runtime) disable the site instance override patches. The intention is to:app.allowRendererProcessReuseto switchapp.allowRendererProcessReusein Electron 9app.allowRendererProcessReusein Electron 10app.allowRendererProcessReusein Electron 11Yes you're reading that right, 5 major versions 👍 (60~ish weeks)
For more info see this Discussion Issue
Checklist
npm testpassesStill TODO
console.warnfor loading native modules in the renderer process that are not context-aware or NAPI - This warning will ship in Electron 7Release Notes
Notes: Added new
app.allowRendererProcessReuseproperty that allows apps to disable the site instance overrides Electron has patched into Chromium. This can be used to prevent the automatic renderer process restarting that Electron currently does.