New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove lingering data when notifications autodismiss on Windows 7 #18401
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
@alespergl Can you take a look at this? |
Is there anyone else who are able to confirm this pull request if @alespergl isn't present? |
This should be good to go, I don't see any harm on this. |
Release Notes Persisted
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Thanks, is there a way to merge this to current versions (5.0.x, 6.0.x) or how does this work? |
/trop run backport-to 6-0-x |
The backport process for this PR has been manually initiated, |
/trop run backport-to 5-0-x |
The backport process for this PR has been manually initiated, |
I have automatically backported this PR to "6-0-x", please check out #18740 |
I have automatically backported this PR to "5-0-x", please check out #18741 |
Description of Change
I Windows 7 notifications that gets auto dismissed (notifications that closes after 4 seconds due to no interaction) won't remove the reference to the notification object which means following notifications that uses the same tag won't be shown.
To solve this issue we need to remove the old reference to the notification within the presenter when a new notification with the same tag is created. Also when a notification is auto dismissed the calls for a manual dismiss is called to remove the notification objets.
Fixes: #11189
Checklist
Release Notes
Notes: Fixed bug where notifications with same tag wouldn't show more than once when first notification was auto dismissed in Windows 7.