Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove lingering data when notifications autodismiss on Windows 7 #18401

Merged
merged 1 commit into from Jun 11, 2019

Conversation

r0stig
Copy link
Contributor

@r0stig r0stig commented May 22, 2019

Description of Change

I Windows 7 notifications that gets auto dismissed (notifications that closes after 4 seconds due to no interaction) won't remove the reference to the notification object which means following notifications that uses the same tag won't be shown.

To solve this issue we need to remove the old reference to the notification within the presenter when a new notification with the same tag is created. Also when a notification is auto dismissed the calls for a manual dismiss is called to remove the notification objets.

Fixes: #11189

Checklist

Release Notes

Notes: Fixed bug where notifications with same tag wouldn't show more than once when first notification was auto dismissed in Windows 7.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 22, 2019
@welcome
Copy link

welcome bot commented May 22, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@deepak1556 deepak1556 requested a review from zcbenz May 22, 2019 18:56
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 23, 2019
@zcbenz zcbenz requested a review from alespergl May 24, 2019 05:15
@zcbenz
Copy link
Member

zcbenz commented May 24, 2019

@alespergl Can you take a look at this?

@r0stig
Copy link
Contributor Author

r0stig commented Jun 10, 2019

Is there anyone else who are able to confirm this pull request if @alespergl isn't present?

@zcbenz
Copy link
Member

zcbenz commented Jun 11, 2019

This should be good to go, I don't see any harm on this.

@zcbenz zcbenz merged commit 0bf83b7 into electron:master Jun 11, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 11, 2019

Release Notes Persisted

Fixed bug where notifications with same tag wouldn't show more than once when first notification was auto dismissed in Windows 7.

@welcome
Copy link

welcome bot commented Jun 11, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@r0stig
Copy link
Contributor Author

r0stig commented Jun 12, 2019

This should be good to go, I don't see any harm on this.

Thanks, is there a way to merge this to current versions (5.0.x, 6.0.x) or how does this work?

@zcbenz
Copy link
Member

zcbenz commented Jun 12, 2019

/trop run backport-to 6-0-x

@trop
Copy link
Contributor

trop bot commented Jun 12, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "6-0-x" here we go! :D

@zcbenz
Copy link
Member

zcbenz commented Jun 12, 2019

/trop run backport-to 5-0-x

@trop
Copy link
Contributor

trop bot commented Jun 12, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Jun 12, 2019

I have automatically backported this PR to "6-0-x", please check out #18740

@trop
Copy link
Contributor

trop bot commented Jun 12, 2019

I have automatically backported this PR to "5-0-x", please check out #18741

@sofianguy sofianguy added this to Fixed in 6.0.0-beta.8 in 6.1.x Jun 17, 2019
@sofianguy sofianguy added this to Fixed in 5.0.4 in 5.0.x Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.4
6.1.x
Fixed in 6.0.0-beta.8
Development

Successfully merging this pull request may close these issues.

Notification with tag works only once
2 participants