Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't package mojom{,-lite}.js files in dist.zip #18444

Merged
merged 1 commit into from May 28, 2019

Conversation

nornagon
Copy link
Member

Description of Change

These files aren't needed for Electron to run. I believe the dependency on them is in error in Chromium, but I'm not sure what the right upstream fix is for now so just masking them out in zip.py.

Checklist

Release Notes

Notes: Removed inadvertently included mojom.js files from distribution bundle.

@nornagon nornagon requested a review from jkleinsc May 24, 2019 18:08
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 24, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 25, 2019
@nornagon nornagon merged commit 2923ae8 into master May 28, 2019
@release-clerk
Copy link

release-clerk bot commented May 28, 2019

Release Notes Persisted

Removed inadvertently included mojom.js files from distribution bundle.

@nornagon
Copy link
Member Author

/trop run backport-to 6-0-x

@trop
Copy link
Contributor

trop bot commented May 28, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "6-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented May 28, 2019

I have automatically backported this PR to "6-0-x", please check out #18486

@trop trop bot added the in-flight/6-0-x label May 28, 2019
@nornagon nornagon deleted the skip-mojom-js-dist branch May 28, 2019 21:11
@sofianguy sofianguy added this to Fixed in 6.0.0-beta.6 in 6.1.x Jun 5, 2019
@miniak
Copy link
Contributor

miniak commented Jul 9, 2019

/trop run backport-to 5-0-x

@trop
Copy link
Contributor

trop bot commented Jul 9, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Jul 9, 2019

I have automatically backported this PR to "5-0-x", please check out #19176

@trop trop bot added the in-flight/5-0-x label Jul 9, 2019
@miniak
Copy link
Contributor

miniak commented Jul 9, 2019

/trop run backport-to 4-2-x

@trop
Copy link
Contributor

trop bot commented Jul 9, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "4-2-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Jul 9, 2019

I have automatically backported this PR to "4-2-x", please check out #19178

@miniak
Copy link
Contributor

miniak commented Jul 10, 2019

/trop run backport-to 5-0-x

@trop
Copy link
Contributor

trop bot commented Jul 10, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Jul 10, 2019

I have automatically backported this PR to "5-0-x", please check out #19192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.7
6.1.x
Fixed in 6.0.0-beta.6
Development

Successfully merging this pull request may close these issues.

None yet

3 participants