New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: contractions handling in spellchecker #18506
fix: contractions handling in spellchecker #18506
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
Removed a debug log I accidentally left in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix 👍
Release Notes Persisted
|
Congrats on merging your first pull request! 🎉🎉🎉 |
I was unable to backport this PR to "5-0-x" cleanly; |
I have automatically backported this PR to "6-0-x", please check out #18538 |
A maintainer has manually backported this PR to "5-0-x", please check out #18548 |
This fixes #18459 by improving the handling of contractions in the spellcheck API. Specifically, it now accepts contraction words where the spellchecker recognizes the whole word, and not, as previously, just if it recognizes all of its parts.
Description of Change
Checklist
npm test
passesRelease Notes
Notes: Spellcheck providers are now (again) called with contractions and their parts