Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contractions handling in spellchecker #18506

Merged
merged 1 commit into from May 31, 2019
Merged

fix: contractions handling in spellchecker #18506

merged 1 commit into from May 31, 2019

Conversation

code-elf
Copy link
Contributor

This fixes #18459 by improving the handling of contractions in the spellcheck API. Specifically, it now accepts contraction words where the spellchecker recognizes the whole word, and not, as previously, just if it recognizes all of its parts.

Description of Change

Checklist

Release Notes

Notes: Spellcheck providers are now (again) called with contractions and their parts

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 29, 2019
@welcome
Copy link

welcome bot commented May 29, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@deepak1556 deepak1556 requested review from nitsakh and zcbenz May 29, 2019 18:38
Copy link
Contributor

@nitsakh nitsakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@code-elf
Copy link
Contributor Author

Removed a debug log I accidentally left in.

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 30, 2019
@codebytere codebytere merged commit ab70e85 into electron:master May 31, 2019
@release-clerk
Copy link

release-clerk bot commented May 31, 2019

Release Notes Persisted

Spellcheck providers are now (again) called with contractions and their parts

@welcome
Copy link

welcome bot commented May 31, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@trop
Copy link
Contributor

trop bot commented May 31, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented May 31, 2019

I have automatically backported this PR to "6-0-x", please check out #18538

@trop
Copy link
Contributor

trop bot commented May 31, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #18548

@trop trop bot added the in-flight/5-0-x label May 31, 2019
@electron electron deleted a comment from trop bot May 31, 2019
@sofianguy sofianguy added this to Fixed in 6.0.0-beta.6 in 6.1.x Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
6.1.x
Fixed in 6.0.0-beta.6
Development

Successfully merging this pull request may close these issues.

New spellcheck API treats contractions as separate words
5 participants