Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove Vulkan mock ICD #18546

Merged
merged 1 commit into from Jun 3, 2019
Merged

Conversation

miniak
Copy link
Contributor

@miniak miniak commented May 31, 2019

Description of Change

Removes from electron.zip:

  • VkICD_mock_icd.dll
  • libVkICD_mock_icd.so

Chrome is not shipping those files either. Follow up to #17985

Checklist

Release Notes

Notes: Removed Vulkan mock ICD from electron.zip, which is only meant to be used for Chromium development.

@miniak miniak self-assigned this May 31, 2019
@miniak miniak marked this pull request as ready for review May 31, 2019 14:19
@miniak miniak requested a review from a team May 31, 2019 14:20
@miniak miniak force-pushed the miniak/remove-vulkan-mock-icd branch from 3f0c1e1 to cdc68a7 Compare May 31, 2019 15:36
build/zip.py Outdated Show resolved Hide resolved
@miniak miniak force-pushed the miniak/remove-vulkan-mock-icd branch from cdc68a7 to 78c72f4 Compare June 3, 2019 17:14
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this'll need a bunch of manual backports unfort

@alexeykuzmin alexeykuzmin merged commit eedbded into master Jun 3, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 3, 2019

Release Notes Persisted

Removed Vulkan mock ICD from electron.zip, which is only meant to be used for Chromium development.

@trop
Copy link
Contributor

trop bot commented Jun 3, 2019

I was unable to backport this PR to "4-2-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jun 3, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jun 3, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/4-2-x label Jun 3, 2019
@alexeykuzmin alexeykuzmin deleted the miniak/remove-vulkan-mock-icd branch June 3, 2019 18:18
@miniak miniak mentioned this pull request Jun 3, 2019
4 tasks
@trop
Copy link
Contributor

trop bot commented Jun 3, 2019

A maintainer has manually backported this PR to "4-2-x", please check out #18594

@trop trop bot added the in-flight/4-2-x label Jun 3, 2019
@miniak miniak mentioned this pull request Jun 3, 2019
4 tasks
@trop
Copy link
Contributor

trop bot commented Jun 3, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #18595

@trop
Copy link
Contributor

trop bot commented Jun 3, 2019

A maintainer has manually backported this PR to "6-0-x", please check out #18596

@sofianguy sofianguy added this to Fixed in 5.0.3 in 5.0.x Jun 4, 2019
@sofianguy sofianguy added this to Fixed in 6.0.0-beta.6 in 6.1.x Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.3
6.1.x
Fixed in 6.0.0-beta.6
Development

Successfully merging this pull request may close these issues.

None yet

4 participants