Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [turbofan] Fix wrong typing of SpeculativeSafeIntegerSubtract #18564

Merged
merged 1 commit into from Jun 3, 2019
Merged

fix: [turbofan] Fix wrong typing of SpeculativeSafeIntegerSubtract #18564

merged 1 commit into from Jun 3, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 1, 2019 •
edited

Description of Change

Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=913296
https://chromium.googlesource.com/v8/v8.git/+/e3c923962677908c183121644c945777cdb31570

[turbofan] Fix wrong typing of SpeculativeSafeIntegerSubtract.

The typing of SpeculativeSafeIntegerSubtract didn't include -0, and the
SimplifiedLowering rules for SpeculativeSafeIntegerSubtract didn't
properly handle the case of -0 - 0, but would always pass Word32
truncations.

/cc @electron/wg-security

Checklist

Release Notes

Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=913296.

@miniak miniak added the 4-2-x label Jun 1, 2019
@miniak miniak requested a review from a team June 1, 2019 21:25
@miniak miniak self-assigned this Jun 1, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 1, 2019
@miniak miniak changed the title fix: [turbofan] Fix wrong typing of SpeculativeSafeIntegerSubtract. fix: Issue 913296: Security: V8: Incorrect type information on SpeculativeSafeIntegerSubtract Jun 1, 2019
@miniak miniak changed the title fix: Issue 913296: Security: V8: Incorrect type information on SpeculativeSafeIntegerSubtract fix: [turbofan] Fix wrong typing of SpeculativeSafeIntegerSubtract Jun 1, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 2, 2019
@miniak miniak added security 🔒 backport This is a backport PR labels Jun 3, 2019
@nornagon nornagon merged commit ec2418a into 4-2-x Jun 3, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 3, 2019

Release Notes Persisted

Backported fix https://bugs.chromium.org/p/chromium/issues/detail?id=913296.

@nornagon nornagon deleted the miniak/backport-913296-4-2-x branch June 3, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees

@miniak miniak

Labels
4-2-x backport This is a backport PR security 🔒
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @zcbenz @nornagon